Backend: Tabs and tabpanel -> wrong aria, and missing tabindex #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angieradtke
changed the title
dgrammatiko
approved these changes
Feb 6, 2025
|
I have tested this item successfully. |
Collaborator
|
Thank you @angieradtke |
|
@dgrammatiko I guess it would need a new release (or tag) here before we can fetch that into the CMS, am I right? If so: Could you do that? |
Collaborator
|
Indeed it needs a new release. I’ll check if I still have the permissions to do and if so I’ll cut a new version tomorrow EDIT: I don't have the npm credentials anymore so someone else needs to publish the new version |
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
had contact to a screenreader-user
Issue:
Backend: Tabs and Tabpanel can be operated using the arrow buttons (OK), but the tabs are also in the focus order (tab order). Only the selected tab may be in the focus order. When I tab through, each tab is "selected", but the selected tab is also "expanded".
We are using the the wrong aria-attributes for the tab-buttons and the tabindex for the button is is not set.
tab-button should have : 'aria-selected instead of aria-expanded (for accordion-button correct) and we need to set the tabindex.