Open
Conversation
Owner
|
Hi, thanks very much for this! I don't use Flowdock, but I'd be happy to merge it in considering the code looks good and this project is still pre version 1.0.0, as long as you're happy with it. If you want to go ahead and do any more testing, just let me know when you're happy and I'll merge it. Thanks! |
Owner
There was a problem hiding this comment.
Just to satisfy my OCD, could you get everything in the following hash indented with two spaces instead of a mixture of 2 and 3? Thanks!
Author
There was a problem hiding this comment.
Of course! Was annoyed by that too, but wanted to make the pull before I fell asleep. Will resolve while testing today
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still needs testing to make sure the format looks good, but wanted to push up a WIP pull request in case anyone else wants to try this.