Open
Conversation
Collaborator
|
Sorry for taking so long to have a look at this. |
22ef412 to
f494578
Compare
c4a2564 to
d974e00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Following #1774 and the modifications proposed in #1776, an alternative structure of the docstring folding code is suggested. The new implementation handles:
"and'delimiters"and') between function signature and its docstringFor each toggling, the function
python-info-docstring-pis used only once. Two new unit tests have been added.This PR was originally submitted at galaunay#6 (and later on moved here).
PR checklist
Please make sure that the following things have been addressed (and check the relevant checkboxes):
For new features only: