Pydantic integration with Jedi 18 fix.#1895
Open
gfederix wants to merge 24 commits intojorgenschaefer:masterfrom
Open
Pydantic integration with Jedi 18 fix.#1895gfederix wants to merge 24 commits intojorgenschaefer:masterfrom
gfederix wants to merge 24 commits intojorgenschaefer:masterfrom
Conversation
… if error occured in rpc-server.
Collaborator
|
Oh my, that is a lot of commits :). Is it ready to be tested and/or used ? |
Author
I broke get_docstring. And this is only visible in emacs tests. ;-( Looks like other code works, but I need time to fix broken before merging. And probably write a regression test. I think I'll fix it in early April. I can also merge my commits into one, if it's convenient. |
2 tasks
Collaborator
|
Well, I am afraid the test suite is not in a good state at the moment. Some tests fails even on the master branch, so nobody should focus too much on them ATM... |
galaunay
force-pushed
the
master
branch
3 times, most recently
from
c4a2564 to
d974e00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
First steps in to integration pydantic.
Jedi16 support has been removed.
Fixed work of Jedi18.
Removed python2 support.
Code reviews and suggestions are welcome. :)
PR checklist
Please make sure that the following things have been addressed (and check the relevant checkboxes):
For new features only: