Conversation
jorio
left a comment
jorio
left a comment
There was a problem hiding this comment.
Thank you for this PR! Please see a few comments in my review.
Annotating the serialization/deserialization code is a bit tricky.
|
|
||
| class JSONEncoderBase16Fallback(json.JSONEncoder): | ||
| def default(self, o: Any): | ||
| __slots__ = () |
There was a problem hiding this comment.
I don't think __slots__ are worth the maintenance overhead in a small project like this. Does mypy need them?
There was a problem hiding this comment.
No, but mypy will give you warnings when accessing attributes that don't exist in slots, and Python will use memory more efficiently when objects have __slots__ defined
Co-authored-by: Iliyas Jorio <iliyas@jor.io>
Co-authored-by: Iliyas Jorio <iliyas@jor.io>#
|
Thank you for these fixes! There seems to be an issue somewhere in the PR that prevents PICT resources from being converted. For example, Nanosaur 1's Application.rsrc has 3 PICT resources (128, 129, 130). On the master branch, (Sorry for the inconvenience – I really ought to write a proper test suite for this tool.) |
2 participants
In this pull request, we fix type issues as reported by mypy.