Refactored the Newsletter and User Controller#30
Open
tejaszambre wants to merge 1 commit intoenginefrom
Open
Conversation
Ashish944
reviewed
Dec 28, 2020
Ashish944
reviewed
Jan 4, 2021
tejaszambre
force-pushed
the
code-refactor
branch
2 times, most recently
from
ef33764 to
5c17279
Compare
tejaszambre
force-pushed
the
code-refactor
branch
from
5c17279 to
97b6e04
Compare
Ashish944
force-pushed
the
code-refactor
branch
from
9cc4181 to
0867c76
Compare
- Updated Newsletter index action method to show newsletter by type - Created single action method to send monthly, opt-in and opt-out newsletter mails - Updated routes according to the below methods - Removed the global send mail and send test buttons and added buttons below individual newsletters. - Added before filters and flash messages in Newsletter and User controller - Added alert message before deleting newsletter - Modified the UI for test mail template - Changed the query for fetching newsletter in opt-in worker, opt-out worker and user worker - Fix test configuration - Fix the bootstrap navbar menu-items active-state issue - Fix the gemfile for test environment - Removed duplicated methods - Updated the depricated deliver method - Fix and modified the test cases for User and Newsletter controller - Rename the newsletter type constant - Fix the user form
Ashish944
force-pushed
the
code-refactor
branch
from
0867c76 to
3475996
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
newsletter mails