Skip to content

Comments

logging format contains process id and thread name also#20

Open
gccode1 wants to merge 1 commit intojosiahcarlson:masterfrom
gccode1:logging-format-update
Open

logging format contains process id and thread name also#20
gccode1 wants to merge 1 commit intojosiahcarlson:masterfrom
gccode1:logging-format-update

Conversation

@gccode1
Copy link

@gccode1 gccode1 commented Oct 3, 2018

It seems to be useful to add process id and thread name in logging. By using this we can distinguish between logging of different processes and different threads which is very useful in debugging.

@josiahcarlson
Copy link
Owner

I like where you are going with this (the ability to change / update the logging message format), but I can't change everyone's logging output going forward without explicitly letting them opt-in.

How are you calling rpqueue? I can probably pull information out of the system environment via os.environ, have a command-line argument --logfmt, or if you need this during load/import, I can probably push all of the logging initialization (and reading of log format config) until after the module has been loaded.

@josiahcarlson josiahcarlson added the more Need more information from OP label Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

more Need more information from OP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants