Flexible column names and dependency issue#3
Open
joshbrowning2358 wants to merge 2 commits intojoyofdata:masterfrom
Open
Flexible column names and dependency issue#3joshbrowning2358 wants to merge 2 commits intojoyofdata:masterfrom
joshbrowning2358 wants to merge 2 commits intojoyofdata:masterfrom
Conversation
This change allows users to use different column names for the prediction and target column names, and it allows users to run the code without explicitly specifying tp/fp costs (assuming they're equal).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for sharing your code! I updated the calculate_roc function to work with my particular dataset (with different column names), and then I thought that you might want to have that update in your repo. I also had errors with running plot_roc without the grid package, so I added that to the plot_roc code.