Add discord rpc #605

ThePotato97 · 2025-04-25T20:14:00Z

closes #186

Add Discord Rich Presence (RPC) Support

This adds basic support for Discord Rich Presence to psst.

If you enable it and provide a valid Discord Application ID, the app will connect to your running Discord client and show the currently playing track in your profile.

Changes

Added a new discord_rpc.rs module under psst-core to manage the Discord RPC connection in a background thread.
Added discord-presence as a new dependency.
Extended the user configuration with two new fields:
- discord_rpc_enable (bool)
- discord_rpc_app_id (string)
Updated the Preferences UI with:
- A checkbox to enable/disable Discord RPC.
- A text field for entering your Discord App ID.
- A button linking to Discord Developer Portal if you need to create one.
Hooked the RPC updates into the PlaybackController:
- Starts the RPC client when enabled (and app ID is valid).
- Updates it live if the App ID changes.
- Shuts it down cleanly when disabled or when quitting.

Behavior

Nothing happens unless the user explicitly enables the feature.
Invalid App IDs are rejected cleanly with warnings.
If playback changes (play, pause, seek, next track), the Discord status updates automatically.
Disconnects and clears the Discord status when pausing or stopping playback.

Notes

Only one new real dependency was added: discord-presence.
Defaults are safe: Discord RPC is disabled by default.

Screenshots

Why

Because Discord status is cool
and now people can see what garbage music you're listening to in real time.

jacksongoode

This is nice - thank you for contributing! but I'd like to do a proper re-review after the unrelated linting changes were resolved.

psst-core/Cargo.toml

psst-core/src/discord_rpc.rs

psst-gui/src/controller/playback.rs

The lsp defaults to 4 spaces for some reason without it

SO9010 · 2025-05-06T08:54:39Z

I had a little skim over this PR! It's looking good so far!

Also I think the taplo.toml shouldn't be included to the PR.

SO9010 · 2025-06-17T22:38:31Z

Just a question, do we have to make it so that the user makes up their ID or are we able to say generate it for them so its more automatic?

Cleboost · 2025-06-30T00:18:31Z

Link #186 to close

Cleboost · 2025-11-27T15:47:48Z

Any news with this pr?

SO9010 · 2025-12-03T09:54:10Z

Just a question, do we have to make it so that the user makes up their ID or are we able to say generate it for them so its more automatic?

jacksongoode · 2025-12-03T10:10:10Z

Just a question, do we have to make it so that the user makes up their ID or are we able to say generate it for them so its more automatic?

Also curious about this. And we should maybe hide the ID once the rpc is connected?

jacksongoode

Here are some more comments, but it looks good, just some note around following Last.fm's scrobbler pattern.

jacksongoode · 2025-12-03T10:11:49Z

psst-core/src/discord_rpc.rs

+                        while !discord_presence::Client::is_ready() {
+                            std::thread::sleep(Duration::from_millis(10));
+                        }


Is 10ms a little too fast for this? Also could there be a case where it never becomes ready? We should have some fallback to kill the loop in that case.

jacksongoode · 2025-12-03T10:12:38Z

psst-core/src/discord_rpc.rs

+                    DiscordRpcCmd::UpdateAppId(new_id) => {
+                        // take the old client out
+                        if let Some(old) = rpc.client.take() {
+                            if let Err(e) = old.shutdown() {
+                                log::warn!("shutdown failed: {}", e);
+                            }
+                        }
+                        // create replacement
+                        match Self::create_client(new_id) {
+                            Ok(new_cli) => rpc.client = Some(new_cli),
+                            Err(e) => log::warn!("failed to create new client: {}", e),
+                        }
+                    }
+                }
+            }
+            // when tx is dropped everywhere, rx returns Err -> loop ends, rpc is dropped


Nit, these comments can be capitalized.

jacksongoode · 2025-12-03T10:13:18Z

psst-gui/src/controller/playback.rs

    None
 }

+fn parse_valid_app_id(id_str: &str) -> Option<u64> {


Could you add a link to some docs as to what is a valid app id?

https://discord.com/developers/docs/reference#snowflakes

jacksongoode · 2025-12-03T10:14:11Z

psst-gui/src/controller/playback.rs

+    fn update_discord_rpc(&mut self, playback: &Playback) {
+        if let Some(now_playing) = playback.now_playing.as_ref() {
+            if let Some(discord_rpc_sender) = &mut self.discord_rpc_sender {
+                let (title, artist, album_name, images, duration, progress) =
+                    match &now_playing.item {


This logic is quite nested, maybe you can opt for some early returns to keep it a little cleaner here.

jacksongoode · 2025-12-03T10:17:09Z

psst-gui/src/controller/playback.rs

                self.report_now_playing(&data.playback);
+                self.update_discord_rpc(&data.playback);


If you have a look at the Last.fm reporting it is inside report_now_playing. We should put the Discord rpc scrobbler there as well and generally follow Last.fm's pattern unless there's some reason not to.

jacksongoode · 2025-12-03T10:17:53Z

psst-gui/src/data/config.rs

    pub lastfm_api_key: Option<String>,
    pub lastfm_api_secret: Option<String>,
    pub lastfm_enable: bool,
+    pub discord_rpc_app_id: String,


Shouldn't this be an Option?

jacksongoode · 2025-12-03T10:18:32Z

psst-gui/src/ui/preferences.rs

+            .with_spacer(theme::grid(1.0))
+            .with_child(
+                Label::new(
+                    "Connects to a running Discord client to display currently playing music",


Suggested change

"Connects to a running Discord client to display currently playing music",

"Connects to a running Discord client to display what's currently playing",

jacksongoode · 2025-12-03T10:18:55Z

psst-gui/src/ui/preferences.rs

+            ))
+            .with_spacer(theme::grid(1.0))
+            .with_child(
+                Button::new("Create a Discord App →")


Like the Last.fm button, I don't think we need the arrow - for consistency sake.

jacksongoode · 2025-12-03T10:19:05Z

psst-gui/src/webapi/client.rs

        self.for_all_pages(request, |page: Page<Option<EpisodeLink>>| {
            if !page.items.is_empty() {
                let ids = page
                    .items
                    .into_iter()
                    .filter_map(|link| link.map(|link| link.id));


Unrelated change?

jacksongoode · 2025-12-03T10:19:15Z

.taplo.toml

@@ -0,0 +1,2 @@
+[formatting]
+indent_string = "  "


Also unrelated?

ThePotato97 added 6 commits April 25, 2025 15:29

Add discord rpc

2bd6566

Prevent discord rpc from blocking main thread

b817a95

discord rpc ui/config stuff

8c76589

change to discord app id instead of client id

b4a0fa5

fix edge case with app id state

df9df9a

add support for podcasts

d709f7b

jacksongoode requested changes Apr 27, 2025

View reviewed changes

psst-core/Cargo.toml Outdated Show resolved Hide resolved

psst-core/src/discord_rpc.rs Outdated Show resolved Hide resolved

psst-gui/src/controller/playback.rs Outdated Show resolved Hide resolved

ThePotato97 force-pushed the discord-rpc branch from aae9446 to d709f7b Compare April 27, 2025 10:56

ThePotato97 added 4 commits April 27, 2025 12:05

added taplo.toml

4b414c8

The lsp defaults to 4 spaces for some reason without it

Remove new lines

d7ef8b3

change all logs to lowercase

2a096de

removed unused crate

e3fa164

ThePotato97 force-pushed the discord-rpc branch from b5eacf2 to e3fa164 Compare April 27, 2025 13:02

Samuel Oldham and others added 2 commits June 17, 2025 23:24

Fix jpochyla#610

b864b70

Merge branch 'main' into discord-rpc

e0e781a

SO9010 force-pushed the main branch from 606534e to 09837ae Compare June 20, 2025 11:44

Copilot AI mentioned this pull request Nov 11, 2025

Add Discord Rich Presence and privacy controls for social presence sharing isaaclins/psst#17

Merged

jacksongoode requested changes Dec 3, 2025

View reviewed changes

		self.report_now_playing(&data.playback);
		self.update_discord_rpc(&data.playback);

	"Connects to a running Discord client to display currently playing music",
	"Connects to a running Discord client to display what's currently playing",

		@@ -0,0 +1,2 @@
		[formatting]
		indent_string = " "

Add discord rpc #605

Are you sure you want to change the base?

Add discord rpc #605

Uh oh!

Conversation

ThePotato97 commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Add Discord Rich Presence (RPC) Support

Changes

Behavior

Notes

Screenshots

Why

Uh oh!

jacksongoode left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SO9010 commented May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SO9010 commented Jun 17, 2025

Uh oh!

Cleboost commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Cleboost commented Nov 27, 2025

Uh oh!

SO9010 commented Dec 3, 2025

Uh oh!

jacksongoode commented Dec 3, 2025

Uh oh!

jacksongoode left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ThePotato97 commented Apr 25, 2025 •

edited

Loading

SO9010 commented May 6, 2025 •

edited

Loading

Cleboost commented Jun 30, 2025 •

edited

Loading