Skip to content

Conversation

@Cleboost
Copy link
Contributor

@Cleboost Cleboost commented Jun 29, 2025

Refactors the playlist widget to improve layout handling for horizontal and sidebar modes, using a unified text_content widget with conditional description display. Replaces the generic placeholder image with a music note icon for playlists without cover art.

This pr fix also some cover that did not load because of WebP format (09b69ab)

If the PR is merged, I will submit a separate PR to introduce compact mode for the whole application.

{9281E4FC-59E9-4F6A-B541-BFAD3D9B864B}
{09F40A93-20A4-4AEE-92FD-2262CE8C6E8F}

Cleboost added 2 commits June 29, 2025 19:49
Refactors the playlist widget to improve layout handling for horizontal and sidebar modes, using a unified text_content widget with conditional description display. Replaces the generic placeholder image with a music note icon for playlists without cover art.
Added 'webp' to the image crate features in Cargo.toml and updated the WebApi client to recognize and handle WebP images. This enables the application to process WebP image formats in addition to JPEG and PNG.
@Cleboost Cleboost changed the title Playlist list Playlist list add cover Jun 29, 2025
Cleboost added 2 commits June 29, 2025 20:05
Deleted the call to .align_vertical(UnitPoint::CENTER) for the playlist image in the playlist_widget function. This changes the alignment behavior of the image in the UI.
Removed French-language comments from the playlist_widget function that were used during development, in order to improve code clarity and maintain consistency in documentation.
@SO9010
Copy link
Collaborator

SO9010 commented Jul 14, 2025

I think submit the fix for the webp format in a different PR for now. I think that this may use up too much UI space.

But again it could be an option. I think we need to have a proper discussion on having a compact mode @jacksongoode We could have a well thought out default compact mode, then minimal with no images or descriptions. Then a maximal including covers like this pr wants to add and perhaps include #662 in with it. I feel if we do that it could be beneficial especially now more network and ram intensive actions are happening like the descriptions for playlists and artist view.

#661 (comment)

@jacksongoode
Copy link
Collaborator

The webp fix is indeed a good one on its own! Yeah theme changes like this are kind of big and the ethos of Psst is to conserve space. This also hinders the initial startup load given that all playlist covers need to populate or load from the cache.

@Cleboost
Copy link
Contributor Author

Check this discussion
#670

@Cleboost
Copy link
Contributor Author

Cleboost commented Jul 14, 2025

I will do an another PR for webp fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants