-
Notifications
You must be signed in to change notification settings - Fork 252
Playlist list add cover #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Refactors the playlist widget to improve layout handling for horizontal and sidebar modes, using a unified text_content widget with conditional description display. Replaces the generic placeholder image with a music note icon for playlists without cover art.
Added 'webp' to the image crate features in Cargo.toml and updated the WebApi client to recognize and handle WebP images. This enables the application to process WebP image formats in addition to JPEG and PNG.
Deleted the call to .align_vertical(UnitPoint::CENTER) for the playlist image in the playlist_widget function. This changes the alignment behavior of the image in the UI.
Removed French-language comments from the playlist_widget function that were used during development, in order to improve code clarity and maintain consistency in documentation.
|
I think submit the fix for the webp format in a different PR for now. I think that this may use up too much UI space. But again it could be an option. I think we need to have a proper discussion on having a compact mode @jacksongoode We could have a well thought out default compact mode, then minimal with no images or descriptions. Then a maximal including covers like this pr wants to add and perhaps include #662 in with it. I feel if we do that it could be beneficial especially now more network and ram intensive actions are happening like the descriptions for playlists and artist view. |
|
The webp fix is indeed a good one on its own! Yeah theme changes like this are kind of big and the ethos of Psst is to conserve space. This also hinders the initial startup load given that all playlist covers need to populate or load from the cache. |
|
Check this discussion |
|
I will do an another PR for |
Refactors the playlist widget to improve layout handling for horizontal and sidebar modes, using a unified text_content widget with conditional description display. Replaces the generic placeholder image with a music note icon for playlists without cover art.
This pr fix also some cover that did not load because of
WebPformat (09b69ab)