Add play button to album and playlist views #666
Conversation
Introduces a play button to both album and playlist detail views, allowing users to start playback directly from these screens. Implements new commands and delegate handling to support playing all tracks from an album or playlist, respecting the current queue behavior (e.g., random or sequential).
|
Can't dev for artist, I can't access to view |
jacksongoode
left a comment
jacksongoode
left a comment
There was a problem hiding this comment.
This looks great, I'll test shortly
|
It would be great to have a different play icon for this as well instead of the duplicate.
I think your token expired. This is a known issue #492 |
|
Thank you, i will check later |
|
Hmm, I was looking at the button and its still a little odd alone there, so I tried putting up near the sort button. What do you think? If you'd like I can push my changes. 
|
|
It looks really good! It's true that it's a bit of a departure from the spotify style :) |
|
@SO9010 Could you have a look over this code, if there are any issues in the implementation? |
|
@Cleboost I don't think you should worry about trying to align to Spotify's UI we are not trying to replicate we are either trying to improve or add functionality. |
|
That's exactly what I'm saying, it allows you to avoid using Spotify's style and have your own UI. |
|
Just a few changes to make the code a tiny bit cleaner, apart from that looks good! |
Changed the function to return early if the items list is empty, reducing nesting and improving readability.
|
I think the play button may be a bit too small now, I think now that there is the play button, we could perhaps add the lyrics button to the top? Reducing the clutter in the bottom bar? @jacksongoode what do you think? I also think that it has to match the player pause functionality otherwise it feels a bit odd. I also have another issue... I think having it follow the player menu doesnt work if its not showing as it will just look like its going somewhere random. Perhaps we should use a custom icon which shows the playmode for this icon. (a little like how spotify does it). Just how do we change it with out access to the playermenu? Having it act as a play/pause function will make more sense as it resets the player otherwise. If you have questions do as I don't think what I said may be the most readable... Edit: I think I also prefer the sorting menu on the left (especially if we potentially move the lyrics button next to it) but I dont really mind @jacksongoode what do you think. |
The bottom playback bar is unique to the currently playing track, we want the lyrics button to be anchored to that. The play button for a view like a playlist operates similarly in theory to the sort (which sorts the viewed list). So I don't think the lyrics button should be moved.
I think it could just be a trigger-able button that triggers playback. We shouldn't have two places where we play and pause the current selection - I think that's kind of odd in spotify's UI. We could possibly disable the button and turn it gray if there's currently something playing? But it also might be fine to allow someone to clear whatever they're playing and start playing the album just by clicking the button. It also brings up the issue of if you click to play an album, then go to another album, will that button show a pause button since we're playing something? That seems unintuitive. I would rather have it be a play trigger for the view's items. |
|
I agree with you for lyric button at the top. The fact that it becomes a full control I'm not sure. I think the best thing is that it remains just a button to start the music and reset the player each time. |
Right now I think sorting might be broken :( but I imagine the album/playlist view playback button would play then sort order of the item list which would be nice to have next to each other then since the sort affect the playback (if not in random mode). |
|
Hmm maybe we change the icon? Or make it disappear? I personally would love it if it could also pause it, seems counterintuitive to have it so that it just plays and nothing else. |
Just submitted a PR to fix it :P |
|
Yeah I'm a fan of greying it out or even make it disappear when not needed. I think that would be good to have with the lyrics button too. For example its not needed in podcasts. |
|
Any news for this features? |
|
Let me just check this out again, it's been a while since I have worked on psst, but I intend on coming back now again. |
|
Personally, I don't like it staying as a play button, if we want it to restart the track, I think we have to make it so that at least the icon changes to represent the restarting of the track. I also still feel like the button is too small. @jacksongoode what do you think as we have different ideas on how this should be apporached. |
|
I'm think it's little bit small than others buttons |
3 participants
Introduces a play button to both album and playlist detail views, allowing users to start playback directly from these screens. Implements new commands and delegate handling to support playing all tracks from an album or playlist, respecting the current queue behavior (e.g., random or sequential).
close #656