Open
Conversation
Contributor
|
@ljqx can you please rebase this against master to make sure the optional attribute is not missing in the JSON tree presentation? |
ljqx
force-pushed
the
logical-assignment
branch
from
f93a8cb to
7b6081b
Compare
ljqx
force-pushed
the
logical-assignment
branch
from
7b6081b to
ef2e509
Compare
Contributor
|
@ariya I've tested this on .NET side and successfully integrated to Jint codebase, passing all tests related to logical assignment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2057.
scanner.tsis updated to accept&&=,||=,??=.parser.tsis updated to treat&&=,||=,??=as assignment operator.