feat(catalogItems): add response type #309
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrl84
requested changes
Apr 15, 2025
Owner
jrl84
left a comment
jrl84
left a comment
There was a problem hiding this comment.
@Roman991 Thanks for the PR. However I would like to request you to refactor it to not use enums.
We are already refactoring to remove enums, please see this conversation and this PR and this additional info.
Contributor
Author
considering that we are inside the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idk how to differentiate the two types of
searchCatalogItems(2020 and 2022)btw this is the 2022 version