grant additional control to determine what logging settings should be honored#30
Open
maxmorlocke wants to merge 1 commit intojschnurr:mainfrom
Open
grant additional control to determine what logging settings should be honored#30maxmorlocke wants to merge 1 commit intojschnurr:mainfrom
maxmorlocke wants to merge 1 commit intojschnurr:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scrapy will by default attach a new root logger to a CrawlerProcess. There is a controllable boolean present in scrapy these days to configure this, so I've created a passthrough boolean with the same name, etc. to attach to it. Otherwise, celery and scrapy fight over control of logging and make it rather hard to keep settings consistent.