Skip to content

Conversation

@kayahr
Copy link
Contributor

@kayahr kayahr commented Jun 3, 2025

Fixes #80

@github-actions
Copy link

github-actions bot commented Jun 3, 2025

Performance impact

Impact on 9 metrics when merging feature/config-file into main. Before drawing conclusion, keep in mind performance variability.

package metrics (+0.5%)
Metric Before merge After merge Impact
import duration 0.2 second 0.2 second +0.001 second / +0.5% ↗️
import memory heap used 8.9 MB 8.9 MB +496 B / +0.006% ↗️
npm tarball size 26.5 kB 26.8 kB +317 B / +1% ↗️
npm tarball unpacked size 115 kB 116 kB +1.1 kB / +1% ↗️
npm tarball file count 23 23 👻
write importmap metrics (-0.3%)
Metric Before merge After merge Impact
write importmap duration 0.2 second 0.2 second -0.002 second / -1% ↘️
write importmap memory heap used 9 MB 9 MB -1.6 kB / -0.02% ↘️
number of fs read operation 0 0 👻
number of fs write operation 8 8 👻
Generated by @jsenv/performance-impact during performance_impact#15428467543 on 29a7de1

@dmail dmail changed the base branch from main to config_file June 5, 2025 10:20
@dmail
Copy link
Member

dmail commented Jun 5, 2025

Very nice.

I'll merge your work into a config_file branch
Then I'll make a PR to add some unit tests to config_file branch + update the package version.

@dmail dmail merged commit dac91fd into jsenv:config_file Jun 5, 2025
5 checks passed
@dmail dmail mentioned this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suggestion: Add support for a simple config file instead of requiring to switch from CLI to API usage

2 participants