Conversation
jserv
force-pushed
the
ci-kitty-integration
branch
3 times, most recently
from
f672677 to
c7eebfa
Compare
This implements CI testing for Kitty Graphics Protocol integration using Xvfb + headless X11 environment with visual verification. - Use latest prebuilt Kitty binary from official installer - Smoke test: launch + auto-quit validation - Visual verification: screenshot capture + brightness analysis (>1000 threshold) - Assert screenshot dimensions (1024x768) to detect Xvfb misconfiguration - Proper DISPLAY handling (inherit from xvfb-run) - 4-second render delay for slow CI runners Visual verification is done with 4-level validation specific to DOOM: 1. Brightness > 1000 (existing) - Ensures non-black frame - Range: 0-65535 (16-bit grayscale) 2. Standard Deviation > 2000 - Detects contrast/variance in image - Prevents solid color or blank screens - DOOM title screen has high contrast (logo, fire, sky) 3. Color Variance: R-B difference > 1000 - DOOM has red/brown logo, blue sky - Detects color variety (not monochrome) - Warning only (not fatal) for flexibility 4. Saturation > 5% - DOOM is colorful, not grayscale - Prevents rendering in wrong color space - HSL colorspace analysis Rationale: - Robust without pixel-perfect fragility - Catches common rendering failures (blank, monochrome, low contrast) - DOOM-specific but not title-screen-specific - Works with any DOOM screen (menu, game, intermission)
jserv
force-pushed
the
ci-kitty-integration
branch
from
c7eebfa to
a9f8cd3
Compare
jserv
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements CI testing for Kitty Graphics Protocol integration using Xvfb + headless X11 environment with visual verification.