Conversation
2. typos fixed 3. Processor changed to Possessor, like they explain in man documentation 4. Backported ARM uniptr's from jsipprell#8 5. Generate better documentation for https://pkg.go.dev/github.com/jsipprell/keyctl 6. UPD travis config to include newer golang versions
jsipprell
requested changes
Oct 19, 2021
Owner
jsipprell
left a comment
jsipprell
left a comment
There was a problem hiding this comment.
This (partially) breaks backwards-compatibility by introducing exported symbol changes. The in-line documentation changes also do not reflect some of the symbol changes.
If we're going to do a change like this it should be separated into backwards and non-backwards compatible PRs.
Author
|
yes, and i have pushed tag to depict version changed |
Owner
|
It's my understanding that mere tagging isn't sufficient. The import path actually needs to change to accomodate a non-backwards compatible v2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.