Fix search output format and remove dead secrets code#168
Conversation
- Updated `GetBibleSearch` in `pkg/app/search.go` to return HTML anchor tags for verses. - Updated `pkg/app/search_test.go` to verify the new HTML format. - Removed `secrets.yaml` generation in `.github/workflows/deployment.yml`. - Removed `secrets.yaml` copy instruction in `Dockerfile`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
- Updated `GetBibleSearch` in `pkg/app/search.go` to return HTML anchor tags for verses. - Updated `pkg/app/search_test.go` and `pkg/app/ask_test.go` to verify the new HTML format. - Removed `secrets.yaml` generation in `.github/workflows/deployment.yml`. - Removed `secrets.yaml` copy instruction in `Dockerfile`.
- Update `pkg/app/passage.go` to prevent extra newlines after spans when followed by `<br>`. - Update `pkg/app/passage_test.go` with reproduction cases and updated expectations. - Update `pkg/app/search.go` to return HTML links for search results. - Update `pkg/app/search_test.go` and `pkg/app/ask_test.go` to match new search output. - Remove `secrets.yaml` related code from `deployment.yml` and `Dockerfile`.
- Extracted `isNextSiblingBr` helper function in `pkg/app/passage.go`. - Simplified `ParseNodesForPassage` to use the helper function instead of inline boolean state. - Verified all tests in `pkg/app` pass.
julwrites
deleted the
fix-search-format-and-secrets-15737576654124430344
branch
1 participant
Updated the Bible search functionality to return results as HTML anchor tags with links, improving usability. Removed dead code related to
secrets.yamlgeneration and usage in the deployment pipeline and Dockerfile, as the application relies on environment variables and Google Secret Manager.PR created automatically by Jules for task 15737576654124430344 started by @julwrites