Open
Conversation
hasnaindev
reviewed
Feb 20, 2021
test/data.test.js
Outdated
|
|
||
| data.forEach((tasbih) => { | ||
| test(`verifying tasbih with id ${tasbih.id} to be unique`, () => { | ||
| expect(tasbihIds.includes(tasbih.id)).toBe(true); |
There was a problem hiding this comment.
Should this not be false? If tasbihIds already include an ID, it means we have found a duplicate. The toBe should take false instead of true.
test/data.test.js
Outdated
| }); | ||
| /* eslint-disable */ | ||
| const data = require('../src/scripts/data/data.json'); | ||
| let tasbihIds = []; |
There was a problem hiding this comment.
We could use Set instead of array too, for now it don't really matter as the data set is very small but something to keep in mind later down the road.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.