refine: Refine error convertion

[junyu0312]

Summary by CodeRabbit

• Refactor
  • Streamlined error handling throughout the codebase by using automatic error conversions instead of manual implementations, improving code maintainability without affecting functionality.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2ece6a60-b321-4da9-8aaf-cfc113610d20

📥 Commits

Reviewing files that changed from the base of the PR and between c3f9c83 and 0154d69.

📒 Files selected for processing (4)

• crates/vm-bootloader/src/boot_loader.rs
• crates/vm-core/src/arch/layout.rs
• crates/vm-core/src/error.rs
• crates/vm-machine/src/error.rs

---

📝 Walkthrough

Walkthrough

This pull request refactors error handling across four crates by replacing manual From trait implementations with the #[from] derive attribute on error enum variants. The changes reduce boilerplate while maintaining equivalent functionality.

Changes

Cohort / File(s)	Summary
Bootloader Error Handling crates/vm-bootloader/src/boot_loader.rs	Added #[from] attribute to LayoutError and GenerateDtb enum variants; removed corresponding manual From impl blocks for layout::Error and vm_fdt::Error.
Core Error Handling crates/vm-core/src/arch/layout.rs, crates/vm-core/src/error.rs	Removed manual From<layout::Error> impl from arch/layout.rs; updated core error enum to use #[from] on KvmError, ApplevisorError, MemoryError, and LayoutError variants, removing three explicit From impl blocks.
Machine Error Handling crates/vm-machine/src/error.rs	Added #[from] attribute to Platform, Device, PciDevice, and Bootloader enum variants; removed four corresponding manual From impl blocks.

Possibly Related PRs

• rust-vm#83: Modifies the Error enum in crates/vm-core/src/error.rs with additional variants and conditional From conversions, creating potential overlap with core error handling changes.
• rust-vm#79: Updates error handling in crates/vm-bootloader/src/boot_loader.rs involving the LayoutError variant and import paths.
• rust-vm#87: Modifies error enums and conversion paths in crates/vm-machine/src/error.rs, directly overlapping with machine-level error refactoring.

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~12 minutes

---

🐰 With derive's magical #[from],
We banish boilerplate and mourn,
Errors now convert with flair,
Less code to write, less code to care! ✨

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch refine

📝 Coding Plan for PR comments

• Generate coding plan

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}