Skip to content

Comments

Support IAM roles and environment variables for credentials#33

Open
larowlan wants to merge 1 commit intojustafish:7.x-2.xfrom
larowlan:2494369-iam-creds
Open

Support IAM roles and environment variables for credentials#33
larowlan wants to merge 1 commit intojustafish:7.x-2.xfrom
larowlan:2494369-iam-creds

Conversation

@larowlan
Copy link

No description provided.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think other Drupal admin pages use "I am..." in the first person for text. How about Use environment variables or IAM roles to manage credentials?

@deviantintegral
Copy link
Collaborator

This fails if you run tests on servers that aren't EC2 (like local environments).

PHPUnit 4.6.6 by Sebastian Bergmann and contributors.

Configuration read from /Users/andrew/vagrant/d7/www/docroot/sites/all/modules/amazons3/phpunit.xml

...............F................................................. 65 / 69 ( 94%)
....

Time: 1.51 seconds, Memory: 53.50Mb

There was 1 failure:

1) Drupal\amazons3\S3ClientTest::testFactoryEnvironmentIAMGetCredentials
Failed asserting that exception of type "\Aws\Common\Exception\InstanceProfileCredentialsException" is thrown.

FAILURES!
Tests: 69, Assertions: 124, Failures: 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants