fix: set SQLite WAL pragmas before transactions in etl-indexer#315
Merged
fix: set SQLite WAL pragmas before transactions in etl-indexer#315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PRAGMA journal_mode=WALwas being executed inside an active transaction, which SQLite disallows.Description
apply_schemaso the schema DDL can run inside transactions without attempting to change journal/safety mode.apply_connection_pragmas(conn: &Connection)that runsPRAGMA journal_mode=WAL;,PRAGMA synchronous=FULL;, andPRAGMA foreign_keys=ON;on the opened connection.apply_connection_pragmasimmediately afterConnection::open(...)in bothmigrate_schemaandbuild_index, beforeconn.transaction()is created.Connection(drop(conn)) after committing the transaction inbuild_indexso WAL-backed changes are flushed before renaming the temporary DB file.Testing
cargo test -p evidenceos-etl-indexerand the previously failing testtests::creates_expected_indexes_and_query_resultsnow passes (all crate tests passed).cargo fmt --all && cargo fmt --checkandcargo clippy --workspace --all-targets -- -D warnings, both succeeded with no errors.cargo test --workspaceand observed no failing tests (FINAL:0).Codex Task