fix: ensure scenario summary artifact is written to CI path#316
Merged
fix: ensure scenario summary artifact is written to CI path#316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
artifacts/scenarios/summary.jsonis produced at the repository root so the CI artifact existence check does not fail when running the scenario system test.Description
scripts/run_scenarios.shto pass an absoluteSCENARIO_ARTIFACT_DIRby settingSCENARIO_ARTIFACT_DIR="$(pwd)/artifacts/scenarios"when invokingcargo test -p evidenceos-daemon --test scenarios_system -- --nocaptureso the test writes into the repo-level artifact directory.Testing
bash scripts/run_scenarios.shand confirmedartifacts/scenarios/summary.jsonexists and is non-empty, rancargo fmt --all && cargo fmt --check, and rancargo test --workspacewith final verification showingFINAL:0.Codex Task