edits to iter_rings, to properly handle 'Z' and prep for other flags#56
Open
abrammer wants to merge 2 commits intojwass:masterfrom
Open
edits to iter_rings, to properly handle 'Z' and prep for other flags#56abrammer wants to merge 2 commits intojwass:masterfrom
abrammer wants to merge 2 commits intojwass:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made some improvements (hopefully) for using this with contour plots as I had the #40 issue then had funky lines due to the #51 "fix". #51 isn't the right solution, as has been mentioned before, while it creates plots it mainly creates broken outputs as the paths become offset.
Zshould draw a line back to the start and yield the path not just append and keep going.I've added in steps draw lines across the bezier curves which I've seen mentioned in issue, these should yield the correct linear path for now and add space for the bezier curve to be added in future.
Also added a contourf "test" which will reveal that #51 doesn't properly solve the problem.
fwiw, I got an indexing method working but it seemed like just running through the list was logically simpler given the variety of SVG codes.