docs: Update SDLC guide for combined checker+autofixer [doc-updater]

[james-in-a-box]

Update documentation to reflect changes from #801 (Reduce implement phase token waste):

• Replace description of separate checker→autofixer loop with combined agent description
• Update "checker agent" reference to "checker+autofixer agent" in per-repo check commands section
• Remove outdated contract fields (autofix_attempts, max_autofix_attempts) and work loop modes table that described the old multi-container retry flow

The orchestrator now runs a single combined agent session that discovers/runs checks and fixes issues inline (up to 3 attempts), rather than spawning separate checker and autofixer containers that communicated via intermediate JSON files.

Triggered by: #801

Authored-by: egg

[egg-reviewer]

No agent-mode design concerns. The documentation update actually improves alignment: replacing the separate checker→autofixer container flow (which relied on intermediate files for communication) with a single combined agent session is a move toward letting the agent explore and fix issues with full context, consistent with guidelines #3 (avoid post-processing pipelines) and #5 (let the agent use judgment).

— Authored by egg

[egg-reviewer]

Review: docs: Update SDLC guide for combined checker+autofixer

Documentation-only change (10 additions, 31 deletions in docs/guides/sdlc-pipeline.md). Verified the changes against the merged PR #801 codebase.

Verified

• "checker+autofixer agent" terminology at line 777: matches the new _build_check_and_fix_prompt function in orchestrator/routes/pipelines.py.
• "Repeats up to 3 times": matches the prompt text at pipelines.py:2735 and pipelines.py:2791.
• Removed contract fields table (autofix_attempts, max_autofix_attempts): these fields are no longer referenced in pipeline execution code. The schema (contract.schema.json) still defines them for backward compatibility with existing contract files, which is fine.
• Removed work loop modes table (full, checks-only): the checks-only mode is no longer referenced in pipeline code.
• New flow diagram accurately reflects the single-session combined agent.

Minor nit (non-blocking)

Line 782: "the checker falls back to auto-discovery" — should say "the checker+autofixer agent falls back to" for consistency with the updated terminology at line 777. Not blocking since this is a pre-existing reference that was outside the diff scope, but worth cleaning up.

Observation (non-blocking)

The Check DAG Configuration section (lines 899-915) still shows a separate fixer step in the ASCII diagram:

merge-fix ─┬─> lint ──┬─> fixer ─> review
           └─> test ──┘

This may be slightly confusing next to the new "Combined Checker+Autofixer Agent" section (lines 917-930), since the old diagram implies a separate fixer step. This was pre-existing and outside PR scope, but a follow-up to reconcile these two sections would help clarity.

Verdict

Changes are accurate and well-scoped. No blocking issues.

— Authored by egg

[james-in-a-box]

Thanks for the thorough review.

Minor nit (line 782): Agreed. Fixed "the checker" → "the checker+autofixer agent" for terminology consistency. Pushed in 203e074.

Observation (Check DAG diagram): Agreed this could be confusing. The DAG section's fixer step predates this PR and reflects the check DAG configuration (which still has a separate fixer step ID in the built-in checks table). I'll leave it out of scope for this PR to avoid scope creep, but it's worth a follow-up to reconcile.

— Authored by egg

[egg-reviewer]

No agent-mode design concerns with the delta. The only change since my last review is a one-line terminology fix ("the checker" → "the checker+autofixer agent") addressing the base reviewer's nit. No new agent-mode implications.

— Authored by egg

[egg-reviewer]

Re-review: docs: Update SDLC guide for combined checker+autofixer

Delta since last review (c07306a → 203e074): Single-line terminology fix on line 782 — "the checker falls back to" → "the checker+autofixer agent falls back to".

Previous feedback status

1. Minor nit (line 782 terminology): Fixed. Line 782 now reads "the checker+autofixer agent falls back to auto-discovery", consistent with the updated terminology at line 777.
2. Observation (Check DAG diagram fixer step): Acknowledged as out-of-scope, follow-up planned. Reasonable — the DAG section reflects the check configuration model which still has a separate fixer step ID.

Re-verification of full PR content

• _build_check_and_fix_prompt function exists at orchestrator/routes/pipelines.py:2701 and is actively called at line 3557. The old _build_checker_prompt and _build_autofix_prompt functions are marked deprecated with zero active callers.
• "Repeats up to 3 times" matches the prompt text at lines 2735 and 2791 of pipelines.py, and is tested in test_pipeline_prompts.py.
• Removed contract fields (autofix_attempts, max_autofix_attempts): confirmed absent from shared/egg_contracts/models.py. The schema may retain them for backward compat, which is fine.
• Removed work loop modes (full, checks-only): no longer referenced in pipeline execution code.

No blocking issues. The terminology fix properly addresses the nit from my first review.

— Authored by egg

[james-in-a-box]

egg review completed. View run logs

5 previous review(s) hidden.