-
Notifications
You must be signed in to change notification settings - Fork 2
Improve gradle buildscript #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Improve gradle buildscript #3
Conversation
Changes: - Use kotlin gradle DSL instead of groovy DSL - Use version catalogs - Modernize some misc. things - Add foojay toolchains resolver plugin - Add some gradle properties that improve performance - Bump java toolchain version to 25
fb436d9 to
78ad3af
Compare
|
Most of these are welcome improvements, but the JDK needs to stay on 23, because that's the version that is included in the OpenJDK extension of the Freedesktop SDK that is used by the GNOME 48 Sdk. I'm pretty sure that JDK 25 will not work; the toolchain resolver can't help us in the offline build process of flatpak-builder. Can you revert that back to JDK 23 and test if the flatpak build still works? |
|
Why not Gnome 49 and JDK 24? |
hmmm, I see tbh I personally would target 21 instead of 23, as even though 23 is the version packaged for gnome 48, 21 is the latest LTS up to you |
|
Java-GI doesn’t support GNOME 49 yet. Likewise, JDK 21 isn’t an option because Java-GI uses the new FFM introduced with JDK 22. |
ah, that sucks in that case I'll revert to 23 later |
|
also, does flatpak have an environment variable or something I can use to detect when the build is happening in a flatpak environmen? because if yes then I'll change the extra repository to only be enabled when being built for a flatpak (alternatively, a kotlin extension function for this could be added to the plugin, similar to these: https://github.com/solo-studios/nyx/blob/master/src/main/kotlin/ca/solostudios/nyx/util/RepositoryHandlerExtensions.kt) |
|
You can check for the |
|
Two more things:
|
Depends on #2
Changes:
I've added multiple dependencies to it even though they're all included by
org.java-gi:adw, as it shows off how to use bundles.