Do not set MT/MD for Windows explicitly.

[csukuangfj]

See also https://www.amd.com/en/developer/resources/technical-articles/2026/a-practical-approach-to-using-sherpa-onnx-production-ready-on-wi.html

Will fix onnxruntime and sherpa-onnx in separate PRs.

[gemini-code-assist]

Summary of Changes

Hello @csukuangfj, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the CMake build configuration by removing specific, hardcoded MSVC runtime library linking options. This change aims to prevent potential conflicts and enhance build system flexibility, especially for Windows environments, by allowing CMake to manage these settings more autonomously. Additionally, it includes a minor version update for the KALDI_DECODER.

Highlights

• CMake Configuration Refinement: Removed explicit add_compile_options for MSVC runtime library linking (/MT, /MTd) in CMakeLists.txt when BUILD_SHARED_LIBS is false. This allows CMake to handle the default runtime library linking, improving build flexibility and compatibility.
• Version Update: The KALDI_DECODER_VERSION in CMakeLists.txt has been incremented from 0.2.10 to 0.2.11.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly removes the explicit setting of the MSVC runtime library flags (/MT, /MTd) for static builds on Windows. This change reverts to CMake's default behavior, which is to use the dynamic runtime (/MD, /MDd). This is a significant improvement as it enhances compatibility with other libraries and prevents potential linking issues that arise from mixing different C++ runtimes. The version update is also noted. The changes are sound and make the build system more robust and flexible.