Open
Conversation
…lint) Add comprehensive security scanning that was missing from CI: - security-scans.yaml: dependency review, shellcheck, YAML lint, Helm lint, Hadolint (Dockerfiles), Trivy (filesystem + IaC), CodeQL (Go SAST), and action pinning verification - scorecard.yaml: OpenSSF Scorecard for repo security posture assessment - dependabot.yaml: add gomod and docker ecosystems (was github-actions only) All actions are SHA-pinned consistent with kagenti-extensions conventions. Scanning jobs start as informational (continue-on-error or exit-code 0) to avoid breaking existing PRs while establishing baseline visibility. Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Paolo Dettori <dettori@us.ibm.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
mrsabath
approved these changes
Mar 11, 2026
Contributor
mrsabath
left a comment
There was a problem hiding this comment.
Review Summary
Well-crafted security scanning addition bringing kagenti-operator CI to parity with kagenti-extensions. All 14 CI checks pass — including the new security scans themselves, which validates the workflows on this very PR.
Highlights:
- All actions SHA-pinned with version comments
- Top-level
permissions: {}with minimal per-job grants - Phased enforcement: informational scans first (Trivy
exit-code: 0, Helm lint|| true), with clear TODOs to tighten persist-credentials: falseon Scorecard checkout- Dependabot expanded to cover
gomodanddockerecosystems - Excellent PR body — tables, design decisions, and post-merge TODO checklist
Areas reviewed: CI/GitHub Actions, Security, YAML
Commits: 1 commit, signed-off ✓, Assisted-By ✓
CI status: all 14 checks passing ✓
Minor suggestions (non-blocking):
pip install yamllint==1.*— wildcard minor version. Consider exact pin for reproducibility.- Action-pinning grep matches 40-char SHA-1 hashes. GitHub is moving to SHA-256 (64 chars) — consider
@[0-9a-f]{40,64}for future-proofing.
LGTM — great addition to the operator's CI pipeline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the security scanning workflows that were missing from kagenti-operator CI, bringing it to parity with kagenti-extensions.
New workflows
security-scans.yamlscorecard.yamlSecurity scans breakdown
actions/dependency-review-actionv4continue-on-erroruntil Dependency Graph enabled)shellcheckyamllinthelm linthadolint-actionv3.3.0aquasecurity/trivy-actionv0.35.0github/codeql-actionv4Dependabot updates
Added missing ecosystems to
.github/dependabot.yaml:gomod—/kagenti-operatordirectorydocker—/kagenti-operatorand/kagenti-operator/cmd/agentcard-signer(Previously only
github-actionswas covered.)OpenSSF Scorecard
Weekly Scorecard run with SARIF upload to GitHub Security tab.
Design decisions
exit-code: 0to avoid blocking PRs while establishing baseline visibility; tighten after initial findings are triagedkagenti-operator/demos(demo manifests, not production)TODO after merge
continue-on-errorneed on dependency-review)exit-code: 1for blockingci.yaml,goreleaser.yml) to SHA commits (currently using@v6/@v7tags)Test plan
security-scans.yamltriggers on this PR