Conversation
…d gem scaffolding
There was a problem hiding this comment.
Pull request overview
This pull request fixes rubocop linting errors and adds standard gem scaffolding files from modern gem generation templates. The changes modernize the codebase to align with current Ruby and rubocop best practices.
Changes:
- Added
# frozen_string_literal: truepragma to all Ruby files for improved performance - Updated rubocop configuration with modernized cop names (e.g.,
Layout/IndentArray→Layout/FirstArrayElementIndentation) - Added standard gem scaffolding files (bin/setup, bin/console, Rakefile, CODE_OF_CONDUCT.md, sig/retriable.rbs)
- Fixed minor code style issues (trailing commas, string freeze removal, blank line spacing, require path)
Reviewed changes
Copilot reviewed 18 out of 20 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| spec/support/exceptions.rb | Added frozen_string_literal pragma |
| spec/spec_helper.rb | Added frozen_string_literal pragma; removed .rb extension from require_relative |
| spec/retriable_spec.rb | Added frozen_string_literal pragma; added trailing comma to hash argument |
| spec/exponential_backoff_spec.rb | Added frozen_string_literal pragma |
| spec/config_spec.rb | Added frozen_string_literal pragma |
| sig/retriable.rbs | Added RBS type signature file for the Retriable module |
| retriable.gemspec | Replaced # coding: utf-8 with # frozen_string_literal: true |
| lib/retriable/version.rb | Added frozen_string_literal pragma; removed .freeze from VERSION string |
| lib/retriable/exponential_backoff.rb | Added frozen_string_literal pragma |
| lib/retriable/core_ext/kernel.rb | Added frozen_string_literal pragma |
| lib/retriable/config.rb | Added frozen_string_literal pragma; added blank line for readability |
| lib/retriable.rb | Added frozen_string_literal pragma; added blank lines for readability |
| bin/setup | Added setup script for gem development environment |
| bin/console | Added console script for interactive gem experimentation |
| Rakefile | Added Rakefile with default tasks for spec and rubocop |
| Gemfile | Added frozen_string_literal pragma; added rake gem dependency |
| CODE_OF_CONDUCT.md | Added Code of Conduct document |
| CHANGELOG.md | Documented the rubocop fixes |
| .rubocop.yml | Updated cop names to modern versions; added new cop configurations |
| .rspec | Added --color flag; added duplicate --require spec_helper |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| --require spec_helper | ||
| --format documentation | ||
| --color | ||
| --require spec_helper |
There was a problem hiding this comment.
The --require spec_helper option is duplicated on lines 1 and 3. Remove the duplicate on line 3 to avoid redundancy.
Suggested change
| --require spec_helper |
| * When interpreting the words and actions of others, participants should always assume good intentions. | ||
| * Behaviour which can be reasonably considered harassment will not be tolerated. | ||
|
|
||
| If you have any concerns about behaviour within this project, please contact us at ["jack@jackchu.com"](mailto:"jack@jackchu.com"). |
There was a problem hiding this comment.
The mailto link should not have quotes around the email address. Change ["jack@jackchu.com"](mailto:"jack@jackchu.com") to [jack@jackchu.com](mailto:jack@jackchu.com). The quotes break the mailto link formatting.
Suggested change
| If you have any concerns about behaviour within this project, please contact us at ["jack@jackchu.com"](mailto:"jack@jackchu.com"). | |
| If you have any concerns about behaviour within this project, please contact us at [jack@jackchu.com](mailto:jack@jackchu.com). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.