Conversation
Simplify configuration by removing most performance-related env vars and hardcoding values optimized for maximum resource usage: - ThreadPoolExecutor: 500 workers (vs default 32) - aiohttp connections: unlimited (limit=0) - curl_cffi pool: 10000 max_clients - Image downloads: no concurrency limit (removed semaphore) Keep only 3 user-configurable limits via env vars: - MAX_USER_QUEUE_SIZE (default 0 = no limit) - STREAMING_DURATION_THRESHOLD (default 300s) - MAX_VIDEO_DURATION (default 0 = no limit)
…adata TikTok's browser impersonation (impersonate=True) doesn't work through HTTP proxies, causing extraction to fail with "Unable to extract webpage video data". Changed approach: - Use direct connection (no proxy) for video info extraction with impersonate - Use proxy for media downloads to hide server IP This fixes the issue where all proxy attempts would fail due to TikTok's JavaScript challenge blocking non-browser requests through proxies.
|
PR Description updated to latest commit (8745d5a) |
|
/review |
PR Reviewer Guide 🔍(Review updated until commit 14c1abe)Here are some key observations to aid the review process:
|
Create the new YoutubeDL instance before closing the old one to ensure we have a valid ydl even if initialization fails.
|
/review |
|
Persistent review updated to latest commit 248c050 |
Return extraction error if video_data is None despite a non-error status code, preventing downstream issues from invalid data.
|
/review |
|
Persistent review updated to latest commit 14c1abe |
User description
Summary
Test plan
PR Type
Bug fix, Documentation
Description
Fix TikTok extraction with proxies using direct connection for metadata
Simplify proxy handling by temporarily disabling it for extraction
Update CODEBASE_MAP.md with new configuration details
Document hardcoded performance values and removed env vars
Diagram Walkthrough
File Walkthrough
client.py
Fix TikTok extraction with proxiestiktok_api/client.py
extraction
ie._extract_web_data_and_status()for both proxy and non-proxycases
CODEBASE_MAP.md
Update codebase documentationdocs/CODEBASE_MAP.md