Convert newRgraphvizInterface.Rnw to newRgraphvizInterface.Rmd#21
Open
sonali8434 wants to merge 4 commits intokasperdanielhansen:develfrom
Open
Convert newRgraphvizInterface.Rnw to newRgraphvizInterface.Rmd#21sonali8434 wants to merge 4 commits intokasperdanielhansen:develfrom
sonali8434 wants to merge 4 commits intokasperdanielhansen:develfrom
Conversation
jwokaty
suggested changes
Jul 28, 2023
Contributor
jwokaty
left a comment
jwokaty
left a comment
There was a problem hiding this comment.
@sonali8434 Thanks for this contribution! This looks good. My only comment is that I don't think fig as in fig=TRUE is an option in R Markdown, although I know it's used in Sweave. It should be removed from lines 289 and 322.
Author
|
@jwokaty done! |
jwokaty
approved these changes
Jul 28, 2023
Contributor
jwokaty
left a comment
jwokaty
left a comment
There was a problem hiding this comment.
@sonali8434 Thanks for catching the one I missed!
@kasperdanielhansen This is ready for your review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jwokaty Kindly Review this PR before we ask @kasperdanielhansen for a final review.
We generally ask one of our team members to review the conversions before asking the maintainers to review it.
@kasperdanielhansen Generally, we give credits to the converter for converting Sweave documents. We ask maintainers if they want us to add ourselves as contributors in the description file and the .Rmd file. I wanted to ask if you would like me to add as a contributor for this conversion. It's totally fine to say no.
After your final review when you merge the PR, remember to bump the version in the DESCRIPTION file so that the Bioconductor build system will recognize the new changes and push the changes to Bioconductor's git repository.
Attached:
Original PDF
Converted HTML