Merged
Conversation
We eventually only want to support building docs from release branches and tags, however, while we're working to initially set up the docs, we may have some churn. So we want to be able to publish from main during that churn. Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
This token was needed when the repos were private. Now that they are public, this should no longer be needed. Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
…pple#82) Append `.git` for `dependencies` in `Package.swift` for consistency.
This is a more appropriate fix for apple#61 - which was closed by use of a workaround. There is no need to unpack image variants that we dont support. Signed-off-by: Aditya Ramani <a_ramani@apple.com>
fixes apple#120 These flags were unused, so remove for clarity. Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
Container services can be started and stopped using the `system start` and `system stop` commands. But there is no straightforward way for users to check if the services were already started. This PR adds a new `system status` command that shows wether the container services are running or not. The command only checks the status of the apiserver for now, but it could be expanded in the future to show more details. Fixes apple#117.
com.apple.container.defaults default subnet key must be network.subnet, not default.subnet. https://github.com/apple/container/blob/ef4462ead7449eba48c0b682b93e30930047f9ef/Sources/Services/ContainerNetworkService/AllocationOnlyVmnetNetwork.swift#L70
Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing out my branch with GitHub issue templates to see if they render how I want them to