DRA-2274: New accessability-improved date picker. #332
Conversation
jesperlauridsen
changed the title
| role="dialog" | ||
| aria-modal="false" | ||
| :aria-labelledby="calendarHeadingId" | ||
| > |
There was a problem hiding this comment.
The calendar if moving by arrow keys left or right. If there are no days from the next or previous month. If you try to go into that month with the arrow keys. It simply wont let you.
It seems the up and down arrow keys works as intended.
src/components/common/TimePicker.vue
Outdated
| </div> | ||
| </template> | ||
|
|
||
| <script setup lang="ts"> |
There was a problem hiding this comment.
This would be the first component with this setup.
|
Looks great! Only found the one functional issue, otherwise it also works great! 😃 |
|
@Pbruun Could you give this another whirl and see if you like it now? |
|
No longer any issues with the calendar, great work! A very nitpicky comment, the next/ previous month arrows seem very "default". Maybe something like the timemachine arrows? Up to you what you think fits. Can't find or think of anything else. 😃 |
|
Just thought of something else for visual improvement. The buttons do not have any hover effect. |
--- THIS IS A DRAFT ---
This is like 90% of the picker done. Im still figuring our some minor isseus here and there, but the main part should be fairly done so you can review it, codewise.
Also, its only on the DayPicker right now (which is the one on the frontpage), the 2 pickers in the filters have not yet been updated