DRA OPTIONAL time search graph changes #334
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en the default. Math log to make the smaller data visible in graph
src/utils/svg-graph.ts
Outdated
| return 95 - ((getBaseLog(logBase, y + 1) - getBaseLog(logBase, minY + 1)) / rangeY) * 95; | ||
| } | ||
| function calculateDefaultDataCurve(logBase: number, y: number, minY: number, maxY: number, rangeY: number) { | ||
| if (y === 0) return 100; |
Contributor
There was a problem hiding this comment.
Generally, in this repo, we've tried to avoid the if one-liners. So, in this case, the "correct" (its a stupid word here, but you get the meaning, we strive for coherence) would be
If(y === 0) {
return 100;
}
This goes for the 2 other if sentences below in this function too :)
Contributor
Author
There was a problem hiding this comment.
It should be "correct" now 😄
jesperlauridsen
requested changes
Jan 23, 2026
Contributor
jesperlauridsen
left a comment
jesperlauridsen
left a comment
There was a problem hiding this comment.
This looks very nice. I only have a simple change request, thats only cosmetic :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 step graph, small data (smallest 1%), medium data (smallest 6%), then the default.
Math log to make the smaller data visible in graph.
This makes sure we can see even the smallest data in the graph. While still keeping the graph difference in the higher end.
The medium graph is there to smooth things between small and default.