Skip to content

SAM-166: Warn users about empty filtered samples #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
charleshtrenholm wants to merge 2 commits into
base: master
Choose a base branch
from
Open

SAM-166: Warn users about empty filtered samples #100

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff2045b
Add field to filter_samplesets report that warns users about empty sa…
charleshtrenholm Feb 25, 2022
9277b20
Merge pull request #99 from charleshtrenholm/warn_empty_filtered_samples
charleshtrenholm Feb 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions lib/sample_uploader/sample_uploaderImpl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,7 +753,7 @@ def filter_samplesets(self, ctx, params):
})

report_client = KBaseReport(self.callback_url)
report_info = report_client.create_extended_report({
report_params = {
'objects_created': [
{
'ref': "/".join([str(info[6]), str(info[0]), str(info[4])])
Expand All @@ -762,7 +762,16 @@ def filter_samplesets(self, ctx, params):
'message': f"SampleSet object named \"{params['out_sample_set_name']}\" \
created with condition(s): {conditions_summary}",
'workspace_name': params['workspace_name']
})
}

if not len(sample_search_api_response['sample_ids']):
warning_msg = "Warning: It appears your filtered sample set contains no samples. \
Attempting to open or view this sample set will result in an error \
from the Sample Service."
report_params['warnings'] = [warning_msg]

report_info = report_client.create_extended_report(report_params)

output = {
'report_name': report_info['name'],
'report_ref': report_info['ref'],
Expand Down