Use 'hostname' instead of 'host', which includes port number.#4
Open
rgould wants to merge 5 commits intokcbanner:masterfrom
Open
Use 'hostname' instead of 'host', which includes port number.#4rgould wants to merge 5 commits intokcbanner:masterfrom
rgould wants to merge 5 commits intokcbanner:masterfrom
Conversation
`url.parse("http://foo.com:444/bar").hostname` returns `"foo.com:444"`,
which causes `validate` to make an invalid call to `https`.
Owner
|
Hey, thanks for this. I'm a bit busy currently but I'll take a look and integrate as soon as I can. |
This permits us to set values like 'rejectUnauthorized'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
url.parse("http://foo.com:444/bar").hostnamereturns"foo.com:444",which causes
validateto make an invalid call tohttps.This permits using a CAS running on a different port.