fix: bump python-keepkey submodule to current master#364
Open
BitHighlander wants to merge 1 commit intomasterfrom
Open
fix: bump python-keepkey submodule to current master#364BitHighlander wants to merge 1 commit intomasterfrom
BitHighlander wants to merge 1 commit intomasterfrom
Conversation
Bumps deps/python-keepkey from 9e4b4f0 to dfe331b (10 commits). Key changes included: - fb4ba4d: regenerate protobuf files (adds MAYAChain + PAYTOTAPROOT types) - 4688afa-1187648: refactor tests for btc-only emulator testing - e9cd6b2: disable .DS_Store tracking This bump is needed so that CircleCI rebuilds kktech/kkemu:latest with the regenerated protobuf files, enabling MAYAChain and P2TR (Taproot) test coverage in downstream projects. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
deps/python-keepkeysubmodule from9e4b4f0todfe331b(10 commits behind current master).Key changes included in the bump:
fb4ba4d4688afa–1187648e9cd6b2Why this matters
The published
kktech/kkemu:latestDocker image is built from this repo'smasterbranch by CircleCI. The current image bakes in the old python-keepkey (9e4b4f0) which lacks:mayachain_get_address,mayachain_sign_tx)PAYTOTAPROOTprotobuf enum (P2TR / Taproot output support)This causes downstream test suites to skip MAYAChain and P2TR tests, even though the firmware itself supports both features since v7.10.0.
Once this merges and CircleCI rebuilds the emulator image, those tests will pass without skip guards.
Testing
-dirtysuffix)dfe331bis current upstreamkeepkey/python-keepkeymaster🤖 Generated with Claude Code