hotfix: add WETH to uniswap token database#173
Open
BitHighlander wants to merge 4 commits intomasterfrom
Open
Conversation
The Uniswap approve liquidity handler (zxappliquid.c) calls
tokenByTicker("WETH") to compute V2 pair addresses via CREATE2.
Without WETH in the token table, the firmware returns false before
any button prompt, causing "Signing cancelled by user" in tests.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fix: add WETH to uniswap token database
The pb2 files were regenerated with a newer protoc (4.x) in fb4ba4d, which emits `from google.protobuf.internal import builder` — an import that only exists in protobuf >= 4.21.0. The CI Docker image (kktech/firmware:v15) runs Python 3.6.9 with protobuf 3.17.3, causing all 73 test modules to fail at import time. Revert to the protoc 3.5.1-generated files (from e9cd6b2) which use the older reflection-based codegen compatible with protobuf 3.x. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This reverts commit 3a2730e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds WETH (Wrapped Ether) to the uniswap token database.
keepkeylib/eth/uniswap_tokens.jsonzxappliquid.cUniswap approve handler which callstokenByTicker(chain_id, "WETH", &WETH)test_sign_uni_approve_liquidity_ETHfailsContext
The firmware's Uniswap liquidity contract handler references WETH by ticker to validate approve transactions for ETH/token liquidity pools. The token was missing from the test library's token database.
Already merged to develop via #172.
Test plan
test_sign_uni_approve_liquidity_ETHpasses in emulator CI