Modernize i2c library with Promises and non-blocking streams #123
Conversation
This commit modernizes the i2c library by introducing several key improvements: - **Promise-based API:** All asynchronous, callback-based methods now have corresponding `Async`-suffixed versions that return Promises, enabling the use of modern `async/await` syntax. This is achieved by leveraging `util.promisify` and is fully backward-compatible. - **Non-Blocking Streams:** The `stream` method has been refactored to use a non-blocking, event-driven architecture. The polling logic has been moved from a blocking `while` loop in the C++ addon to a `setInterval`-based implementation in JavaScript. This improves efficiency and aligns with Node.js best practices. - **Refactored C++ Addon:** The C++ `ReadBlock` function has been simplified to perform a single, non-blocking read, making the native code cleaner and more maintainable. - **Updated `package.json`:** The `package.json` file has been updated with modern metadata, including `keywords`, `homepage`, and `bugs` fields, and the `author` and `repository` fields have been standardized.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This submission modernizes the i2c library by adding a Promise-based API, refactoring the streaming implementation to be non-blocking, and updating the
package.jsonfile with modern metadata. The C++ addon has also been simplified to improve maintainability. These changes make the library more efficient, easier to use, and aligned with modern Node.js best practices.PR created automatically by Jules for task 13746904769279578246 started by @kelly