Modernize C++ Addon with N-API and Promisify API #135
Conversation
Refactored the native addon from Nan to N-API for ABI stability. Updated the JavaScript API from callbacks to a class-based async/await model. Re-implemented streaming in a non-blocking way in JavaScript. Updated example to reflect the new API.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This submission modernizes the C++ addon by migrating from Nan to N-API, ensuring ABI stability across Node.js versions. It also refactors the public JavaScript API to use a modern,
async/await-based class, improving developer experience and code readability. The streaming functionality has been re-implemented in a non-blocking manner in JavaScript, and the example code has been updated to reflect these changes.PR created automatically by Jules for task 5458714970595012928 started by @kelly