This repository was archived by the owner on Dec 1, 2018. It is now read-only.
return resp.content instead of resp.text for logs#154
Open
de1o wants to merge 1 commit intokelproject:masterfrom
Open
return resp.content instead of resp.text for logs#154de1o wants to merge 1 commit intokelproject:masterfrom
de1o wants to merge 1 commit intokelproject:masterfrom
Conversation
requests will treat content encoding as ISO-8859-1 when encoding is not present in response header, which cause resp.text messed up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requests will treat content encoding as ISO-8859-1 when encoding is not
present in response header, which cause resp.text messed up.