This repository was archived by the owner on Dec 1, 2018. It is now read-only.
support updating container images as per kubectl set-image#70
Open
jcderr wants to merge 1 commit intokelproject:masterfrom
Open
support updating container images as per kubectl set-image#70jcderr wants to merge 1 commit intokelproject:masterfrom
jcderr wants to merge 1 commit intokelproject:masterfrom
Conversation
|
@brosner can you please take a look at this change, I believe it will be nice to have such a feature |
|
Hey, I implemented this method in my product and it worked as expected. +1 |
brosner
suggested changes
Mar 6, 2017
Contributor
brosner
left a comment
There was a problem hiding this comment.
I am a little concerned by this change for a couple of reasons:
imagegetter/setter is dealing with multiple images. The correct naming should beimagesIMO.- Implementing these methods on
ReplicatedMixinis going to lead to misleading on expected behavior IMO. While we are just doing object updates, I'd like to try to avoid cases where every object inheriting fromReplicatedMixinwould behave the same. For example, the only object that inherits fromReplicatedMixinthat would behave likeset-image(which is actually replica sets) isDeployment.
Due to this being an improved API over what is already possible, I'd like to punt to another release. I think there is merit in this change, but needs to be more thought through when exposing object attributes at the Python object namespace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.