Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have an issue with the newest nuget of PCLMock (4.0.0 right now), and it seems reproducible in current master. When I launch console with only vs2017 installed, I've got the following exception:
This may be fixed by putting the dll into GAC, but you have to do it on every developer's machine. Therefore I tried to upgrade Microsoft.CodeAnalysis nuget packages to the newest versions and it fixed the problem for me.
I had to increase minimum .Net framework version because the newest nugets rely on .Net standard 1.3 which is implemented for .Net 4.6.0 and newer.