WMI: improve logging and handle array variants

[doomedraven]

This PR improves WMI logging in capemon:

• Switches to case-insensitive string comparisons (_wcsicmp) for WMI properties like __CLASS, __PATH, etc.
• Adds basic handling for VT_ARRAY variant types in logs to avoid 'Unhandled' messages for arrays.
• Removes redundant 'Class' parameter in WMI_Get/Next logging calls where it was not providing extra value.

[gemini-code-assist]

Summary of Changes

Hello @doomedraven, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the WMI logging capabilities within capemon by making property comparisons more flexible and improving the handling of complex data types. The changes aim to reduce noise in logs by properly identifying array variants and removing unnecessary details, leading to clearer and more accurate WMI event reporting.

Highlights

• Case-Insensitive WMI Property Comparisons: Switched string comparisons for WMI properties like __CLASS, __PATH, etc., from wcscmp to _wcsicmp to ensure case-insensitive matching, improving robustness.
• WMI Array Variant Handling: Implemented basic handling for VT_ARRAY variant types in the logging mechanism to prevent 'Unhandled VARIANT Type' messages when encountering arrays.
• Refined WMI Logging Parameters: Removed the redundant 'Class' parameter from LOQ_hresult logging calls in WMI_Get and WMI_Next, streamlining log output.

Changelog

• hook_wmi.c
  • Replaced wcscmp with _wcsicmp for case-insensitive comparisons of WMI property names.
  • Removed the 'Class' parameter from LOQ_hresult calls in WMI_Get and WMI_Next functions.
• log.c
  • Added a check for VT_ARRAY in the log_variant function to specifically log 'Array' instead of 'Unhandled VARIANT Type' for array variants.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces several improvements to WMI logging, such as switching to case-insensitive string comparisons and handling array variant types, which are positive changes. However, I have concerns about the removal of the WMI class name from the logging calls in WMI_Get and WMI_Next. This change, while aiming for conciseness, removes valuable context from the logs, potentially making analysis more difficult. I've left specific comments suggesting that this information be restored.