feat: add configurable mining screenshot timing#891
feat: add configurable mining screenshot timing#891khajiitvaper2017 wants to merge 4 commits intokillergerbah:mainfrom
Conversation
|
This change breaks the existing "image screenshot delay" setting and replaces it with |
|
"image screenshot delay" was gated behind extension, so I moved it to Mining tab |
|
Screenshot delay was under the streaming video section because the feature only makes sense for streaming video where playing the subtitle being mined is part of the normal mining UX. This isn't true for the local video player where screenshots are taken instantly from the timestamp the user is at. What are you addressing by moving "image screenshot delay" out of the streaming video section? |
I see, yeah you're right. When you use that button it takes screeshot from the beginning of the subtitle. Would this address your use-case?
With this type of configuration it feels like we are doing more with less. Same setting, just additional and more flexible behavior. |
|
created separate PR #897 |

Description
Often the beginning of a subtitle corresponds to an image of the previous speaker or scene. In anime especially, scenes tend to start from the feet and pan up to the head.
To address this, I added configurable timing for mined subtitle screenshots with the following options:
Changes
Adds configurable timing for mined subtitle screenshots and wires it through the full mining pipeline.
miningScreenshotCaptureTimestamp, with options ranging from subtitle start to end.VideoPlayer) and the extension mining flow.