feat: Implement testing framework with Vitest and JSDOM#15
Open
killerwolf wants to merge 4 commits intomainfrom
Open
feat: Implement testing framework with Vitest and JSDOM#15killerwolf wants to merge 4 commits intomainfrom
killerwolf wants to merge 4 commits intomainfrom
Conversation
This commit introduces a testing framework to the project using Vitest and JSDOM. Key changes include: - Added `vitest` and `jsdom` as development dependencies. - Created a `vitest.config.js` for basic JSDOM environment configuration. - Updated npm scripts in `package.json` to include `test` and `test:watch` commands. - Implemented initial unit tests for core `VisualImageTool` functionalities in `src/visual-image-tool.test.js`. This covers instantiation, focus point retrieval and manipulation, and the destroy method. - Updated the GitHub Actions workflow (`.github/workflows/code-quality.yml`) to include a new job that runs `npm test` on pushes and pull requests to the main branch. - Added a "Running Tests" section to `README.md` to guide contributors on how to execute the tests. This addresses issue #8, enhancing the project's reliability and maintainability by providing a solid foundation for testing.
This commit reverts the `lint` and `format` scripts in `package.json` to their original state, as the previous commit inadvertently modified them beyond the scope of the original issue. The scripts for Vitest remain in place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a testing framework to the project using Vitest and JSDOM.
Key changes include:
vitestandjsdomas development dependencies.vitest.config.jsfor basic JSDOM environment configuration.package.jsonto includetestandtest:watchcommands.VisualImageToolfunctionalities insrc/visual-image-tool.test.js. This covers instantiation, focus point retrieval and manipulation, and the destroy method..github/workflows/code-quality.yml) to include a new job that runsnpm teston pushes and pull requests to the main branch.README.mdto guide contributors on how to execute the tests.This addresses issue #8, enhancing the project's reliability and maintainability by providing a solid foundation for testing.