feat: Add loading spinner during image initialization#19
Open
killerwolf wants to merge 1 commit intomainfrom
Open
feat: Add loading spinner during image initialization#19killerwolf wants to merge 1 commit intomainfrom
killerwolf wants to merge 1 commit intomainfrom
Conversation
Adds a visual loading spinner to the `visual-image-tool`. The spinner is displayed when the tool is instantiated and the image is loading. It is hidden once the image is fully loaded and the tool's UI elements are ready. This improves your experience by providing visual feedback during the initial loading phase, preventing the perception of unresponsiveness. Changes include: - Added `this.spinnerElement` and `this.initialLoadComplete` fields. - Created and styled a spinner DIV element in `_prepareContainer()`. - Added CSS keyframes for the spinner animation. - Implemented logic in `_updateScaling()` to hide the spinner upon initial image load. - Ensured the spinner element is removed in the `destroy()` method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a visual loading spinner to the
visual-image-tool.The spinner is displayed when the tool is instantiated and the image is loading. It is hidden once the image is fully loaded and the tool's UI elements are ready.
This improves your experience by providing visual feedback during the initial loading phase, preventing the perception of unresponsiveness.
Changes include:
this.spinnerElementandthis.initialLoadCompletefields._prepareContainer()._updateScaling()to hide the spinner upon initial image load.destroy()method.