EU FLEX - User Interface II - Zakaria TOUZRI 🇫🇷#1
Open
killinq-joke wants to merge 4 commits intomasterfrom
Open
EU FLEX - User Interface II - Zakaria TOUZRI 🇫🇷#1killinq-joke wants to merge 4 commits intomasterfrom
killinq-joke wants to merge 4 commits intomasterfrom
Conversation
killinq-joke
changed the title
killinq-joke
changed the title
killinq-joke
changed the title
NabeelahY
changed the title
NabeelahY
reviewed
Dec 5, 2019
| - [x] Go to your [index.html](great-idea-website/index.html) file and build out your HTML structure. You have been provided all the content and images you need to get started inside the `index.html` file. Start to code HTML around the content! | ||
|
|
||
| - [ ] Style your HTML using the [desktop design file](design-files/desktop.jpg) as a visual guide. Use any CSS properties you want for general styling but for layout, you can only use the box model (content, padding, margin, border) and `display:inline-block`. | ||
| - [x] Style your HTML using the [desktop design file](design-files/desktop.jpg) as a visual guide. Use any CSS properties you want for general styling but for layout, you can only use the box model (content, padding, margin, border) and `display:inline-block`. |
| display:inline; | ||
| } | ||
|
|
||
| div{ |
Collaborator
There was a problem hiding this comment.
This div style might override other styles. I'll advise that you give each div their own class to make it easily selectable.
| button{ | ||
| border:1px solid black; | ||
| padding:10px 50px; | ||
| margin-bottom: 40%; |
Collaborator
There was a problem hiding this comment.
I'll advise that you add bottom margin to the container wrapping the button and text. Easier to style
| </section> | ||
| <section> | ||
| <h2 class="contact">Contact</h2> | ||
| <ul> 123 Way 456 Street</ul> |
Collaborator
There was a problem hiding this comment.
Remeber <ul> is used to wrap <li> items. Like this
<ul>
<li></li>
<li></li>
</ul>
Collaborator
|
The final webpage looks great! Just a few tweaks and its good to go. Great job 👍🏽 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.