-
Notifications
You must be signed in to change notification settings - Fork 288
refactor: setAccessible no longer effect since PHP 8.1 #439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @ddevsr, can you use the |
|
You mean new constant Edit: Ohh ok use |
b7b0980 to
97e3c54
Compare
|
I'd use Could you run |
Update ClassStaticsPlugin.php Update ClassStringsPluginTest.php Update DomPluginTest.php Update SimpleXMLElementPluginTest.php refactor: using constant KINT_PHP81 instead run composer format run composer build
97e3c54 to
71490e0
Compare
|
I see what's happening, php-cs-fixer is reordering some docblocks and that's making the build fail. Can you run a |
|
Push unecessary file in this PR? |
|
Nah, if you have the php-cs-fixer version in the lockfile (So just a If you don't want to Edit: If that's too much I could rebuild it for you and push the PR manually |
|
Merged as 33e535c |
|
@jnvsor Tagged new version for support PHP 8.5 soon? |
|
@ddevsr before php8.5 release yes, but because kint is very sensitive to very niche parts of PHP I like to leave it as late as possible before release since even with a feature freeze there can be breaking changes in the last week Edit: but if you're concerned about the version constraint in codeigniter don't worry, I don't put upper version limits on kint so it probably won't break anything to just leave it on the current version so long as you're not committing the lockfile or update the version when updating to 8.5 |
cc @jnvsor