Enable "always open in current container" configuration by domain

[dmorlitz]

This pull request creates an "always open in current container" function - configured via the UI. The format of the configuration variable is a pipe (|) separated list of domain names which will always open in the current tab regardless of domain rules. This enables the same domain to open in multiple containers - and to support sites that must remain in the same container as the site that launched it - such as PayPal.

The configuration variable is used in a regex and each domain name must be followed by a / The code adds the ( and )/ to the regex.

[mikijov]

@kintesh , can you comment on this PR? I think it is a very useful feature.

[dmorlitz]

Nathan has taken this feature beyond my implementation at https://github.com/nwg/containerise-ce It might be worth looking at his changes as well

…

On Sat, Jan 29, 2022 at 1:15 PM Milutin Jovanović ***@***.***> wrote: @kintesh <https://github.com/kintesh> , can you comment on this PR? I think it is a very useful feature. — Reply to this email directly, view it on GitHub <#167 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC3NKESEAJFXQZEBAOXBILTUYQVEBANCNFSM5H27USAA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[kintesh]

@mikijov @dmorlitz I will have a look at this soon.

[WolfRevo]

@mikijov @dmorlitz I will have a look at this soon.

Did you have a chance to check this PR?
If not did you think about giving some of your contributors the right to merge and release new versions?

[dmorlitz]

I have passed control of this code to someone else who has forked containerise at https://github.com/nwg/containerise-ce - because there didn’t seem to be active development here Since Firefox brought out Total Cookie Protection, I have stopped using containers. Any code I contributed here is open for anyone to take over.

…

On Wed, Mar 8, 2023 at 7:38 AM WolfRevo ***@***.***> wrote: @mikijov <https://github.com/mikijov> @dmorlitz <https://github.com/dmorlitz> I will have a look at this soon. Did you have a chance to check this PR? If not did you think about giving some of your contributors the right to merge and release new versions? — Reply to this email directly, view it on GitHub <#167 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC3NKEVP6JKUBVFOQ6ADRRLW3B4TZANCNFSM5H27USAA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[WolfRevo]

I have passed control of this code to someone else who has forked containerise at https://github.com/nwg/containerise-ce - because there didn’t seem to be active development here Since Firefox brought out Total Cookie Protection, I have stopped using containers. Any code I contributed here is open for anyone to take over.
…
On Wed, Mar 8, 2023 at 7:38 AM WolfRevo @.> wrote: @mikijov https://github.com/mikijov @dmorlitz https://github.com/dmorlitz I will have a look at this soon. Did you have a chance to check this PR? If not did you think about giving some of your contributors the right to merge and release new versions? — Reply to this email directly, view it on GitHub <#167 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC3NKEVP6JKUBVFOQ6ADRRLW3B4TZANCNFSM5H27USAA . You are receiving this because you were mentioned.Message ID: @.>

Thx for clarification! Your argument is fair enough.

[kaushikgopal]

I created Container Traffic Control fwiw which handles the ultimate goal of this issue (but it's implemented slightly differently).

• in CTC, multiple containers can match the same url
• but there's a checkbox for "preference"
  • this means, if you're opening a url from scratch it picks the container with "preference"
  • alternatively, if you're in a container that supports opening the url, you will remain in the same container.

[WolfRevo]

@kaushikgopal

1. you should clearly mark your addon to be created with the help of AI
2. what about cloud sync of the rules?
3. is there a way to import the json from containerise?

[kaushikgopal]

1. I actually wrote an entire blog post detailing it. but out of curiosity may I ask why? (I see it akin to tooling at this point) but trying to understand the underlying concern that is alleviated by indicating AI was used to build the plug in.
2. rules are indeed automatically synced natively with Firefox.
3. this is interesting but I thought it more helpful to build out the rules manually vs importing cause it might not be a 1-1 port. CTC introduces the notion of a container "type" as well. it's not technically hard cause eventually the data structure is a table of rules but I feel it'll be more confusing if I assume a container type.

[WolfRevo]

Thanks for the hint. Didn't see your blog post as I was triggered by your last comment right here and just checked your github repo. Need some time to read but looks interesting.
As I am working in security I consider AI coding basically a security risk if not manually reviewed by experienced human eyes. That's why I at least like to see clear and transparent information when AI is used for any kind of creation, that's all.
Back to topic 👍 I will have a look at your add-in if it is suitable for my needs and could replace containerise (which I maintain for myself in another fork).